[AutoDiff] Define derivative for concrete SIMD.init(repeating:) #81864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @JaapWijnen |
|
@swift-ci please test |
The PR swiftlang#81766 introduced some concrete SIMD operations, but `init(repeating:)` was temporarily disabled due to differentiation testing break. See: stephentyrone@7a00619 This PR contains two changes: 1. Define custom derivatives for concrete `init(repeating:)` so we do not fall into non-differentiability error diagnostic. 2. Add a fix to SIL linker so differentiability witness lookup is done when the original function has both `@_alwaysEmitIntoClient` and `@_transparent`. Similar changes were introduced previously in swiftlang#78908, but they only handled `@_alwaysEmitIntoClient` without `@_transparent`.
kovdan01
force-pushed
the
autodiff-simd-concrete-float-init
branch
from
3089b0f to
25f789e
Compare
|
@swift-ci please test |
stephentyrone
approved these changes
May 30, 2025
| @@ -455,3 +455,34 @@ where | |||
| return (Self(repeating: value), { v in Self(repeating: v) }) | |||
| } | |||
| } | |||
|
|
|||
| %for (Scalar, bits) in [('Float16',16), ('Float',32), ('Double',64)]: | |||
There was a problem hiding this comment.
You can remove the Float16 piece here.
There was a problem hiding this comment.
Removed in 591e19c, thanks
| % if bits == 16: | ||
| #if !((os(macOS) || targetEnvironment(macCatalyst)) && arch(x86_64)) | ||
| @available(SwiftStdlib 5.3, *) | ||
| % end |
There was a problem hiding this comment.
And remove this and the trailing if block as well
There was a problem hiding this comment.
Removed in 591e19c, thanks
|
@swift-ci please test |
stephentyrone
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #81766 introduced some concrete SIMD operations, but
init(repeating:)was temporarily disabled due to differentiation testing break. See:stephentyrone@7a00619
This PR contains two changes:
Define custom derivatives for concrete
init(repeating:)so we do not fall into non-differentiability error diagnostic.Add a fix to SIL linker so differentiability witness lookup is done when the original function has both
@_alwaysEmitIntoClientand@_transparent. Similar changes were introduced previously in [AutoDiff] Support custom derivatives for @_alwaysEmitIntoClient functions #78908, but they only handled@_alwaysEmitIntoClientwithout@_transparent.