AST: Build availability scopes for custom domain conditionals #80428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…yContext`. Preparation for building availability scopes for `if #available` statements that query non-platform availability domains.
…ptional. Rather than representing a missing availability range on `PoundAvailableInfo` with a default-constructed `AvailabilityRange` (empty), store the ranges as optionals instead. This allows an empty range to represent an availability condition which is known to be false at compile time, which will be necessary when generating SIL for `if #available` queries that check custom availability domains.
tshortli
force-pushed
the
custom-availability-domain-scopes
branch
2 times, most recently
from
bb7fbf5 to
1bfd367
Compare
…mains. Resolves rdar://138441298 and rdar://138441307.
tshortli
force-pushed
the
custom-availability-domain-scopes
branch
from
1bfd367 to
303f7d8
Compare
tshortli
changed the title
|
@swift-ci please smoke test |
tshortli
requested review from
hborla,
slavapestov,
xedin,
jckarter,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro and
rjmccall
as code owners
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the
AvailabilityScopetree, construct scopes correctly for queries like this:This ensures the regions inside the then and the else branches are type-checked correctly. Also, update SILGen to handle these conditionals. If the availability of the custom domain is known at compile time, then the branches of the conditional must be compiled accordingly by constant-folding the branches.
Resolves rdar://138441307 and rdar://138441298.