[Completion] Handle unbound generics in typealiases #80343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham and
rintaro
as code owners
slavapestov
reviewed
Mar 27, 2025
slavapestov
reviewed
Mar 27, 2025
slavapestov
reviewed
Mar 27, 2025
hamishknight
force-pushed
the
out-of-bounds
branch
3 times, most recently
from
58fa840 to
def5d28
Compare
|
Spoke to Slava offline, updated to remove the use of |
rintaro
approved these changes
Apr 1, 2025
The underlying type for a typealias can be an unbound generic type, replace these with the bound generic equivalent. This avoids crashing when attempting to compute the type relation (in the future we'll want to open these type parameters for the comparison). rdar://147789214
hamishknight
force-pushed
the
out-of-bounds
branch
from
def5d28 to
f0c3861
Compare
|
@swift-ci please smoke test |
rintaro
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying type for a typealias can be an unbound generic type, replace these with the bound generic equivalent. This avoids crashing when attempting to compute the type relation (in the future we'll want to open these type parameters for the comparison).
rdar://147789214