Skip to content

Ensure we're commuting instructions only when internal one has a single use. #79511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

asl
Copy link
Contributor

@asl asl commented Feb 20, 2025

Fix couple of similar single use predicates while there.

Fixes #78848

@asl asl requested a review from eeckstein as a code owner February 20, 2025 06:05
@asl
Copy link
Contributor Author

asl commented Feb 20, 2025

@swift-ci please test

@asl asl added SILOptimizer Area → compiler: SIL optimization passes SIL ownership Area → compiler → SIL: SIL ownership labels Feb 20, 2025
@eeckstein
Copy link
Contributor

Can you add test cases for this?

@asl
Copy link
Contributor Author

asl commented Feb 20, 2025

Can you add test cases for this?

Well, the ultimate testcase is in the tree, just requires ownership modules as you mentioned :) Let me see if it would be possible to add SIL-to-SIL negative tests here.

asl added 2 commits February 24, 2025 13:59
use. Fix couple of similar single use predicates while there.

Fixes #78848
@asl
Copy link
Contributor Author

asl commented Feb 24, 2025

@eeckstein Added for both interesting cases

@asl
Copy link
Contributor Author

asl commented Feb 24, 2025

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Feb 24, 2025

Tagging @JaapWijnen

@asl
Copy link
Contributor Author

asl commented Feb 25, 2025

@swift-ci please test windows platform

@asl
Copy link
Contributor Author

asl commented Feb 26, 2025

Windows seems to be broken on main

@asl
Copy link
Contributor Author

asl commented Feb 27, 2025

@swift-ci please test windows platform

@asl
Copy link
Contributor Author

asl commented Feb 27, 2025

@eeckstein will you please check when you will have some time?

Thanks!

@asl
Copy link
Contributor Author

asl commented Mar 10, 2025

@eeckstein ping

@asl
Copy link
Contributor Author

asl commented Mar 20, 2025

@eeckstein will you please check when you will have some time?

Thanks!

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@eeckstein eeckstein merged commit 962be95 into main Mar 21, 2025
5 checks passed
@eeckstein eeckstein deleted the 78848-fix branch March 21, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIL ownership Area → compiler → SIL: SIL ownership SILOptimizer Area → compiler: SIL optimization passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SILCombine for differential_function creates SIL with invalid ownership when enabling OSSA modules
2 participants