-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Ensure we're commuting instructions only when internal one has a single use. #79511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Can you add test cases for this? |
Well, the ultimate testcase is in the tree, just requires ownership modules as you mentioned :) Let me see if it would be possible to add SIL-to-SIL negative tests here. |
use. Fix couple of similar single use predicates while there. Fixes #78848
@eeckstein Added for both interesting cases |
@swift-ci please test |
Tagging @JaapWijnen |
@swift-ci please test windows platform |
Windows seems to be broken on |
@swift-ci please test windows platform |
@eeckstein will you please check when you will have some time? Thanks! |
@eeckstein ping |
@eeckstein will you please check when you will have some time? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Fix couple of similar single use predicates while there.
Fixes #78848