[Backtracing] Fix bug in Compact Image Map decoder. #79394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `expand` opcode was being decoded incorrectly in the case where we were trying to expand prefixes with codes of 64 or above. rdar://144497804
|
@swift-ci Please smoke test |
mikeash
approved these changes
Feb 14, 2025
Sort of. There isn't a comprehensive suite of tests for the encoder/decoder; I would have liked to, but that would take more time than I have available right now. In lieu of that, what there is a test that captures the image map on the test system, compresses it, then decompresses it and checks that it matches. That's what picked this problem up, but it's obviously somewhat dependent on everyone running the test with their machines in different states. I have manually tested the fix with the data from the bug report we got. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expandopcode was being decoded incorrectly in the case where we were trying to expand prefixes with codes of 64 or above.rdar://144497804