Skip to content

[CSOptimizer] A few improvements to inference and ranking #79309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

[CSOptimizer] A few improvements to inference and ranking #79309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a422325
[CSOptimizer] Improve contextual result type handling during overload…
xedin Feb 6, 2025
2a273a1
[CSOptimizer] Infer result types through ternary expressions
xedin Feb 6, 2025
8eb1b7c
[CSOptimizer] Infer argument candidates through optionals
xedin Feb 6, 2025
dcf2195
[CSOptimizer] Allow matching against CGFloat as a contextual result type
xedin Feb 6, 2025
100c4ec
[CSOptimizer] Infer types from init calls used as arguments
xedin Feb 6, 2025
096633e
[CSOptimizer] Don't reduce the ranking for non-default literal types
xedin Feb 6, 2025
451d61a
[CSOptimizer] Add support for `??` operator
xedin Feb 7, 2025
575189c
[Tests] NFC: Add a test-case with literal chain passed as an argument…
xedin Feb 8, 2025
001d446
[CSOptimizer] Emulate old hack for unary argument matching more preci…
xedin Feb 8, 2025
eb80e7f
[CSOptimizer] Always prefer a disjunction with a single active chocie
xedin Feb 9, 2025
f642f84
[CSSolver] Attempt choices marked as disfavored at the end of partition
xedin Feb 9, 2025
9eabb63
[CSOptimizer] Expand literal support to bools, strings and dictionaries
xedin Feb 11, 2025
188c02c
[CSOptimizer] Support non-operator generic choices with simple signat…
xedin Feb 11, 2025
3b5ec46
[CSOptimizer] Introduce a way to prefer disjunctions before scores ar…
xedin Feb 12, 2025
2f418f4
[CSOptimizer] Disfavor operators some non-generic choices over all-ge…
xedin Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/swift/Sema/CSBindings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,12 @@ class BindingSet {
void forEachLiteralRequirement(
llvm::function_ref<void(KnownProtocolKind)> callback) const;

void forEachAdjacentVariable(
llvm::function_ref<void(TypeVariableType *)> callback) const {
for (auto *typeVar : AdjacentVars)
callback(typeVar);
}

/// Return a literal requirement that has the most impact on the binding
/// score.
LiteralBindingKind getLiteralForScore() const;
Expand Down
Loading