[ASTGen] Generate anonymous closure parameters #79232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
astgen-closure-anonparam
branch
from
b6fa326 to
cb049d8
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Feb 10, 2025
Comment on lines
+138
to
+139
| return llvm::isa_and_present<swift::ClosureExpr>( | ||
| llvm::dyn_cast<swift::AbstractClosureExpr>(dc.unbridged())); |
There was a problem hiding this comment.
I believe you should be able to directly check for ClosureExpr since that implements classof for DeclContext
Comment on lines
+143
to
+144
| return llvm::cast<swift::ClosureExpr>( | ||
| llvm::cast<swift::AbstractClosureExpr>(dc.unbridged())); |
Comment on lines
+317
to
+329
| let param = BridgedParamDecl.createParsed( | ||
| self.ctx, | ||
| declContext: expr.asDeclContext, | ||
| specifierLoc: nil, | ||
| argName: nil, | ||
| argNameLoc: nil, | ||
| paramName: ctx.getDollarIdentifier(idx), | ||
| paramNameLoc: loc, | ||
| type: nil, | ||
| defaultValue: nil | ||
| ) | ||
| param.setSpecifier(.default) | ||
| param.setImplicit() |
There was a problem hiding this comment.
IMO it would be nicer to expose a createImplicit method, but I don't feel too strongly about it
Comment on lines
+1237
to
+1239
| case UInt8(ascii: "0")...UInt8(ascii: "9"): | ||
| let digit = Int(c &- UInt8(ascii: "0")) | ||
| result = result * 10 + digit |
There was a problem hiding this comment.
Huh TIL we allow $0001
|
Let me address the review comments in followups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
$0Unlike C++ parser, scan the body for
$nreferences upfront to createParameterList, before generating the body.