[CS] Avoid penalizing holes for placeholder vars for completion #79217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing completion in a result builder, we avoid solving unrelated expressions by replacing them with unbound placeholder variables. Avoid penalizing assigning holes to these placeholders, since otherwise we end up unnecessarily exploring the entire solution space, and bailing due to too complex. rdar://144382123
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
hborla and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
xedin
approved these changes
Feb 7, 2025
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing completion in a result builder, we avoid solving unrelated expressions by replacing them with unbound placeholder variables. Avoid penalizing assigning holes to these placeholders, since otherwise we can end up unnecessarily exploring the entire solution space, and bailing due to too complex.
Resolves #79213
rdar://144382123