🍒 [6.1] Indexing: add blocklist support for avoiding indexing specific module names #79064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test |
artemcm
approved these changes
Jan 30, 2025
bnbarham
reviewed
Jan 31, 2025
… names Indexing while building sometimes triggers module deserialization issues, exemplified by a recent issue of rdar://141357099. This change introduces the blocklist support to avoid indexing specific module names so we could rely on external data source for unblocking builds, instead of modifying the compiler source. Resolves: rdar://143770366
nkcsgexi
force-pushed
the
block-list-module-index
branch
from
7d6a01e to
f06660a
Compare
|
@swift-ci please test |
bnbarham
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Indexing while building sometimes triggers module deserialization issues, exemplified by a recent issue of rdar://141357099. This change introduces the blocklist support to avoid indexing specific module names so we could rely on external data source for unblocking builds, instead of modifying the compiler source.
Scope: Indexing while building
Risk: Very Low.
Testing: Manually tested with actual project that enables indexing-while-building
Cherry-picked PR: Indexing: add blocklist support for avoiding indexing specific module names #78984
Reviewer: @artemcm @bnbarham
Issue: rdar://143770366