-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[embedded] Support _findStringSwitchCaseWithCache in Embedded Swift #78915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kubamracek
merged 3 commits into
swiftlang:main
from
kubamracek:embedded-string-switch-with-cache
Jan 28, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
92b0c5f
[embedded] Support _findStringSwitchCaseWithCache in Embedded Swift
kubamracek e1d22b5
[embedded] Avoid changing lookupStdlibFunction, load findStringSwitch…
kubamracek 500f8ad
[embedded] Only treat findStringSwitchCaseWithCache as anchor in earl…
kubamracek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// RUN: %target-run-simple-swift(-enable-experimental-feature Embedded -wmo -O -Xlinker %swift_obj_root/lib/swift/embedded/%target-cpu-apple-macos/libswiftUnicodeDataTables.a) | %FileCheck %s | ||
|
||
// REQUIRES: swift_in_compiler | ||
// REQUIRES: executable_test | ||
// REQUIRES: optimized_stdlib | ||
// REQUIRES: swift_stdlib_no_asserts | ||
// REQUIRES: OS=macosx | ||
// REQUIRES: swift_feature_Embedded | ||
|
||
enum MyEnum: String { | ||
case case1 | ||
case case2 | ||
case case3 | ||
case case4 | ||
case case5 | ||
case case6 | ||
case case7 | ||
case case8 | ||
case case9 | ||
case case10 | ||
case case11 | ||
case case12 | ||
case case13 | ||
case case14 | ||
case case15 | ||
case case16 | ||
case case17 | ||
case case18 | ||
case case19 | ||
} | ||
|
||
var e = MyEnum.case1 | ||
print(e.rawValue) | ||
e = MyEnum.case2 | ||
print(e.rawValue) | ||
// CHECK: case1 | ||
// CHECK: case2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable approach