Skip to content

[stdlib] Add Comparable conformance to WordPair #78857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jan 23, 2025

The initial PR to add WordPair to the stdlib forgot to include the proposed Comparable conformance. Let's add it. Unfortunately the conformance itself will have a higher availability than the type itself, but the function alone can share the availability of the type at least.

@Azoy Azoy requested a review from a team as a code owner January 23, 2025 18:10
@Azoy
Copy link
Contributor Author

Azoy commented Jan 23, 2025

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Jan 23, 2025

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Jan 23, 2025

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Jan 23, 2025

@swift-ci please smoke test

@glessard
Copy link
Contributor

@swift-ci please smoke test macOS platform

@glessard
Copy link
Contributor

@swift-ci please smoke test Windows platform

@Azoy
Copy link
Contributor Author

Azoy commented Jan 28, 2025

@swift-ci please smoke test

@Azoy Azoy merged commit 0572eb9 into swiftlang:main Jan 29, 2025
3 checks passed
@Azoy Azoy deleted the wordpair-comparable branch January 29, 2025 19:21
Azoy added a commit to Azoy/swift that referenced this pull request Feb 6, 2025
[stdlib] Add Comparable conformance to WordPair
@xwu
Copy link
Collaborator

xwu commented Feb 15, 2025

@Azoy Does the main branch need to be amended to reflect availability in Swift 6.1 now that the cherrypicking PR is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants