-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Add Comparable conformance to WordPair #78857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please smoke test |
glessard
approved these changes
Jan 23, 2025
thomasvl
reviewed
Jan 23, 2025
@swift-ci please smoke test |
thomasvl
reviewed
Jan 23, 2025
@swift-ci please smoke test |
glessard
approved these changes
Jan 23, 2025
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
@swift-ci please smoke test Windows platform |
@swift-ci please smoke test |
Azoy
added a commit
to Azoy/swift
that referenced
this pull request
Feb 6, 2025
[stdlib] Add Comparable conformance to WordPair
@Azoy Does the main branch need to be amended to reflect availability in Swift 6.1 now that the cherrypicking PR is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR to add
WordPair
to the stdlib forgot to include the proposedComparable
conformance. Let's add it. Unfortunately the conformance itself will have a higher availability than the type itself, but the function alone can share the availability of the type at least.