[cxx-interop] Fix wrong calling convention for some C++ types #78544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We erroneously used @autoreleased convention for C++ types in some scenarios.
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan and
jckarter
as code owners
|
@swift-ci please test |
fahadnayyar
approved these changes
Jan 11, 2025
rjmccall
approved these changes
Jan 13, 2025
Thanks! If anything falls out in the follow-up discussion I will address it in a follow-up PR.
This was the weirdest part, I hit this with value types as well and eventually it even triggered some crashes. We have special handling for foreign references in place, so I hope this code path would be triggered by value types. |
Xazax-hun
added a commit
that referenced
this pull request
Jan 14, 2025
[cxx-interop] Fix wrong calling convention for some C++ types
|
Alright. Values returned by C++ are definitely returned at +1, so that would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We erroneously used @autoreleased convention for C++ types in some scenarios.