RedundantLoadElimination: correctly handle end_borrow instructions #77618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope-ending instructions, like `end_borrow` are only irrelevant for RLE if the preceding load is not changed. If it is changed from `load [copy]` -> `load [take]` the memory effects of those scope-ending instructions prevent that the `load [take]` will illegally mutate memory which is protected from mutation by the scope. Fixes a memory verifier crash rdar://139824805
|
@swift-ci test |
|
@swift-ci benchmark |
meg-gupta
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope-ending instructions, like
end_borroware only irrelevant for RLE if the preceding load is not changed. If it is changed fromload [copy]->load [take]the memory effects of those scope-ending instructions prevent that theload [take]will illegally mutate memory which is protected from mutation by the scope.Fixes a memory verifier crash
rdar://139824805