[Completion] Type-check parent closures for local functions #77537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid type-checking local decls and macros, the type-checking here should instead be handled by TypeCheckASTNodeAtLocRequest.
Really this applies to any capture, not just `self`. Also refactor to make it clear that parent closures and functions are really the only cases that matter here.
Local functions can capture variables from parent closures, so we need to make sure we type-check parent closures when doing completion in a local function. Ideally we ought to be able to be more selective about the elements of the parent closure that we type-check, but that's a more complex change I'm leaving as future work for now.
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
hborla,
xedin and
slavapestov
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
xedin
reviewed
Nov 12, 2024
| if (!ctx.CompletionCallback) { | ||
| // Type-check any local decls encountered. | ||
| for (auto *D : LocalDeclsToTypeCheck) | ||
| TypeChecker::typeCheckDecl(D); |
There was a problem hiding this comment.
Maybe we should skip adding them to the local decls and macro lists?
There was a problem hiding this comment.
Sure, I don't mind
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
Nov 12, 2024
hamishknight
added a commit
that referenced
this pull request
Nov 13, 2024
[Sema] NFC: Address review feedback on #77537
SharonXSharon
pushed a commit
to SharonXSharon/swift
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local functions can capture variables from parent closures, so we need to make sure we type-check parent closures when doing completion in a local function. Ideally we ought to be able to be more selective about the elements of the parent closure that we type-check, but that's a more complex change I'm leaving as future work for now.
Resolves #77305