[Sema] Consistently run MiscDiagnostics on macro arguments #77534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these walkers ought to be walking into non-PatternBinding decls, this avoids duplicate diagnostics in nested local decls in closures.
Previously we would only run MiscDiagnostics passes on macro arguments for some statement diagnostics, update the expression walkers that inherit from BaseDiagnosticWalker such that we consistently do MiscDiagnostics on macro arguments.
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Nov 11, 2024
xedin
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would only run MiscDiagnostics passes on macro arguments for some statement diagnostics, update the expression walkers that inherit from BaseDiagnosticWalker such that we consistently do MiscDiagnostics on macro arguments.