Skip to content

[CMake] Get ELF SwiftRT building #77469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented Nov 7, 2024

These patches add the missing header search paths for building the swiftrt.o, as well as adding it to the default settings when building for BSD and Android to ensure that it isn't forgotten.

The ELF SwiftRT includes some headers from the compiler include
directories. Adding those search paths so that it builds.
BSD and Android also need to build swiftrt.o so adding it to the
default settings.
@etcwilde
Copy link
Member Author

etcwilde commented Nov 7, 2024

@swift-ci please smoke test

@etcwilde
Copy link
Member Author

etcwilde commented Nov 8, 2024

Linux failure:

******************** TEST 'lldb-shell :: SwiftREPL/BreakpointSimple.test' FAILED ********************
Exit Code: -9
Timeout: Reached timeout of 600 seconds

Command Output (stderr):
--
RUN: at line 3: /home/build-user/build/buildbot_linux/lldb-linux-x86_64/bin/lldb --no-lldbinit -S /home/build-user/build/buildbot_linux/lldb-linux-x86_64/test/Shell/lit-lldb-init-quiet --repl < /home/build-user/llvm-project/lldb/test/Shell/SwiftREPL/BreakpointSimple.test | /home/build-user/build/buildbot_linux/llvm-linux-x86_64/bin/FileCheck /home/build-user/llvm-project/lldb/test/Shell/SwiftREPL/BreakpointSimple.test
+ /home/build-user/build/buildbot_linux/lldb-linux-x86_64/bin/lldb --no-lldbinit -S /home/build-user/build/buildbot_linux/lldb-linux-x86_64/test/Shell/lit-lldb-init-quiet --repl
+ /home/build-user/build/buildbot_linux/llvm-linux-x86_64/bin/FileCheck /home/build-user/llvm-project/lldb/test/Shell/SwiftREPL/BreakpointSimple.test

--

@etcwilde
Copy link
Member Author

etcwilde commented Nov 8, 2024

@swift-ci please test Linux

@etcwilde
Copy link
Member Author

etcwilde commented Nov 8, 2024

@swift-ci please test macOS

@etcwilde etcwilde merged commit 794a96f into swiftlang:main Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants