Fix partial apply forwarder emission for coroutines that are methods of structs with type parameters #76743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of structs with type parameters. Simplify the code while here
|
@swift-ci please test |
|
@asavonic Will you please review? |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
Thank you! Looks much better now. |
|
@aschwaighofer @rjmccall Will you please take a look? |
|
@rjmccall @eeckstein @aschwaighofer Friendly ping |
|
Another ping. Thanks! |
|
@DougGregor @tkremenek Is there anything that could be done to get this reviewed? |
drexin
approved these changes
Nov 20, 2024
|
Sorry that got lost. LGTM |
|
@aschwaighofer @drexin Thanks! |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code while here.
This refactors some implementation bits of #71653 (and effectively reverts some parts of it). In particular, it implements the coroutine call in terms of CallEmission rather than relying on implementation details of CallEmission.