Skip to content

[6.0.x] Remove libicu build and update list of Swift runtime libraries to be de-duplicated #76613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

finagolfin
Copy link
Member

@finagolfin finagolfin commented Sep 20, 2024

Explanation: Libicu is entirely unused on non-Darwin platforms too since the Foundation re-core to use _FoundationICU, so shave 35 MB off the 6.0 non-Darwin toolchains by removing it. Also, update the list of libraries that are deduplicated by the autolink-extract tool.

Scope: Only affects code for non-Darwin platforms, that is now entirely unused.

Issue: None

Original PRs: #75262, #75342, and #76224

Risk: Very low

Testing: Passed all CI on trunk

Reviewer: @jmschonfeld @compnerd @parkera @etcwilde

We are unnecessarily still shipping libicu in the 6.0 toolchains despite having another copy in lib_FoundationICU. This was removed in 6.1 months ago without a problem.

@finagolfin finagolfin requested a review from a team as a code owner September 20, 2024 18:32
@finagolfin
Copy link
Member Author

@jmschonfeld, need a CI run here.

@jmschonfeld
Copy link
Contributor

@swift-ci please test

@finagolfin
Copy link
Member Author

Passed CI, just needs approval from @compnerd and other owners.

@finagolfin
Copy link
Member Author

@shahmishal, let me know what you think as the linux platform manager about shaving these unused libraries off the 6.0 toolchain in a patch release.

@shahmishal
Copy link
Member

I would like to get a review from @parkera and @airspeedswift.

@parkera
Copy link
Contributor

parkera commented Sep 24, 2024

I don't want to aggressively cherry pick this back without any evidence that it resolves the named bug. We're already doing it on main, though.

@finagolfin
Copy link
Member Author

@parkera, this has nothing to do with any bug, I think you might have got this mixed up with #76606. This is just about a simple cleanup on the toolchain for libicu libraries that are now unused on linux and Windows after the Foundation re-core, which uses _FoundationICU instead.

@parkera
Copy link
Contributor

parkera commented Sep 24, 2024

Ok, thanks

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine since we've already landed similar changes on main. I see it as an opportunity fix to along with other changes already staged for a 6.0.x but not a driver for the release itself.

@finagolfin
Copy link
Member Author

Ping @shahmishal, do we need anyone else to sign off? I think you and I pinged all relevant reviewers weeks ago.

@finagolfin
Copy link
Member Author

Ping @airspeedswift, I think Mishal just wanted you to sign off.

@finagolfin
Copy link
Member Author

Ping @shahmishal, would be good to get this in before the next patch release.

@shahmishal
Copy link
Member

cc: @airspeedswift

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should take this

@DougGregor
Copy link
Member

It's been a while, so re-running CI before merging

@DougGregor
Copy link
Member

@swift-ci please test

@finagolfin
Copy link
Member Author

Passed CI, ready for merge.

@DougGregor DougGregor merged commit f4db3a2 into swiftlang:release/6.0 Dec 3, 2024
5 checks passed
@finagolfin finagolfin deleted the link-icu branch December 3, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants