Skip to content

SILGen: Remove triplesAreValidForZippering() assert #76276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

SILGen: Remove triplesAreValidForZippering() assert #76276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/SILGen/SILGenDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,7 +1771,6 @@ SILValue SILGenFunction::emitZipperedOSVersionRangeCheck(
// macCatalyst process it will use the iOS version.
llvm::Triple VariantTriple = *getASTContext().LangOpts.TargetVariant;
llvm::Triple TargetTriple = getASTContext().LangOpts.Target;
assert(triplesAreValidForZippering(TargetTriple, VariantTriple));

// From perspective of the driver and most of the frontend,
// -target and -target-variant are symmetric. That is, the user
Expand Down
1 change: 1 addition & 0 deletions lib/Serialization/SerializedModuleLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,6 +1323,7 @@ bool swift::extractCompilerFlagsFromInterface(
// we have loaded a Swift interface from a different-but-compatible
// architecture slice. Use the compatible subarchitecture.
for (unsigned I = 1; I < SubArgs.size(); ++I) {
// FIXME: Also fix up -target-variant (rdar://135322077).
if (strcmp(SubArgs[I - 1], "-target") != 0) {
continue;
}
Expand Down
5 changes: 5 additions & 0 deletions validation-test/ParseableInterface/rdar133020098.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// RUN: %target-swift-frontend -typecheck %s

// REQUIRES: OS=macosx

import System