Add --preset-vars-file to build-script for easier preset vars handling
#76058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci build toolchain |
|
@swift-ci smoke test macos |
|
macOS toolchain failure is unrelated |
|
@swift-ci build toolchain macos |
edymtt
approved these changes
Aug 23, 2024
etcwilde
approved these changes
Aug 23, 2024
|
@swift-ci build toolchain macos |
andrurogerz
pushed a commit
to andrurogerz/swift
that referenced
this pull request
Sep 3, 2024
…dling (swiftlang#76058) It's not always convenient to pass preset substitution arguments on an interactive command-line. Sometimes one might also need to generate these vars automatically, outside of a `build-script` invocation and also store those vars in a file for later reuse. This change adds a new optional `--preset-vars-file` customization point to `build-script`, which allows users to pass a a file with newline separated key-value pars for preset variables substitution in addition to passing those in a direct `build-script` invocation.
MaxDesiatov
added a commit
that referenced
this pull request
Dec 18, 2024
Currently, usage of `--preset-vars-file` (added in #76058) introduces newlines in values of preset variables passed via this file. Calling `strip()` will remove trailing and preceding whitespace characters, including newlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not always convenient to pass preset substitution arguments on an interactive command-line. Sometimes one might also need to generate these vars automatically, outside of a
build-scriptinvocation and also store those vars in a file for later reuse.This change adds a new optional
--preset-vars-filecustomization point tobuild-script, which allows users to pass a a file with newline separated key-value pars for preset variables substitution in addition to passing those in a directbuild-scriptinvocation.