Adding more comment for Reflection tests that does not support ASAN #75519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding more comment for "UNSUPPORTED: asan".
Adding more comment for "UNSUPPORTED: asan".
Adding more comment for "UNSUPPORTED: asan".
Adding more comment for "UNSUPPORTED: asan".
Adding more comment for "UNSUPPORTED: asan".
Adding more comment for "UNSUPPORTED: asan".
Adding more comment for "UNSUPPORTED: asan".
|
Looks good. The specific problem is that |
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
Adding comment for "// REQUIRES: reflection_test_support"
|
Dear @tbkka , Sure. Thank you for your advice. I updated all of them. Please help me to review it. Thanks, |
|
Looks great! Let's make sure it passes CI, then I'll merge it. |
|
@swift-ci Please test |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As reference the PR #75509 (Reflection tests are incompatible with ASAN), Adding more comment on some files in Reflection tests
Modifications:
Result:
Adding more "UNSUPPORTED: asan"