[Concurrency] Remove redundant Sendable conformances in the standard library.
#75495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d library. These conformances are all redundant because the `Sendable` conformance is inherited from a superclass.
hborla
commented
Jul 26, 2024
| @@ -511,6 +505,3 @@ extension _DictionaryStorage { | |||
| return storage | |||
| } | |||
| } | |||
|
|
|||
| extension _DictionaryStorage: @unchecked Sendable | |||
There was a problem hiding this comment.
I believe this unchecked Sendable conformance was incorrect, and _DictionaryStorage inherits an unavailable Sendable conformance from __RawDictionaryStorage.
There was a problem hiding this comment.
Yeah I think you're right about this. Should be fine to remove 👍
|
@swift-ci please smoke test |
Azoy
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These conformances are all redundant because the
Sendableconformance is inherited from a superclass. This resolves a slew of concurrency warnings about redundantSendableconformances which were introduced by #75135.