Warn about sending on Sendable type in function parameters (#74616) #74849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Androp0v
requested review from
hborla,
slavapestov,
xedin and
AnthonyLatsis
as code owners
hborla
reviewed
Jul 14, 2024
hborla
reviewed
Jul 14, 2024
|
I'll address your comments and update the PR, thanks @hborla |
Androp0v
force-pushed
the
feat/warn-about-sending-on-sendable
branch
2 times, most recently
from
34c0961 to
9c01b64
Compare
|
FYI: I didn't add tests for: Due to #74846 |
…#74616) When a function parameter is Sendable, adding 'sending' annotation does nothing, as the value is safe to be sent across isolation boundaries. SE-0430 seems to imply that 'sending' is intended to be used for non-Sendable types only.
Androp0v
force-pushed
the
feat/warn-about-sending-on-sendable
branch
from
9c01b64 to
f200dae
Compare
…Sendable type Follow PR review comments and extend the warnings about sending on sendable types to cover types with a type parameter, and use generic signature instead of ASTContext to check conformance to Sendable. Additionally, use different warning messages based on whether the sending on Sendable is used on a function parameter or function result.
Androp0v
force-pushed
the
feat/warn-about-sending-on-sendable
branch
from
f200dae to
c34376b
Compare
Androp0v
requested review from
xymus,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function parameter is Sendable, adding 'sending' annotation does nothing, as the value is safe to be sent across isolation boundaries. SE-0430 seems to imply that 'sending' is intended to be used for non-Sendable types only.
Includes fix-it to remove 'sending' from parameter.
Addresses #74616 .