Skip to content

[6.0] [Completion] Completions for inout, borrowing, consuming, isolated, consume, and copy #74526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link
Contributor

6.0 cherry-pick of #74331

  • Explanation: Add completion support for a bunch of new keywords (and inout)
  • Scope: Affects completion in parameter type position and decl position
  • Issue: rdar://127261573
  • Risk: Low
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

These are official features now (SE-0377). This
allows them to show up in code completion.
Defining it as a `DECL_KEYWORD` means code
completion will try and complete it in decl
position. It shouldn't really be considered a decl
keyword, so define it as `SWIFT_KEYWORD`.
Complete ownership specifiers such as `consuming`,
`borrowing`, and `inout` in parameter type
position. While here, also complete `isolated`.

rdar://127261573
These are part of SE-0366 and SE-0377 respectively.
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels Jun 18, 2024
@hamishknight hamishknight requested a review from bnbarham June 18, 2024 20:04
@hamishknight hamishknight requested a review from a team as a code owner June 18, 2024 20:04
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 5c01ca1 into swiftlang:release/6.0 Jun 19, 2024
5 checks passed
@hamishknight hamishknight deleted the keyword-completion-6.0 branch June 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants