[CS] Fill in ErrorTypes for expressions that fail to type-check #74423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please SourceKit stress test |
Ensure we always produce typed AST, even if we fail to apply a solution. This fixes a cursor info issue where we'd to type-check a closure twice due to it not having a type set. rdar://129417672
hamishknight
force-pushed
the
fully-typed
branch
from
b41a26c to
5ec4d1c
Compare
|
@swift-ci please test |
xedin
approved these changes
Jun 17, 2024
ahoppen
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we always produce typed AST, even if we fail to apply a solution. This fixes a cursor info issue where we'd to type-check a closure twice due to it not having a type set.
rdar://129417672