Skip to content

Fix LLDB Swift data formatters breaking Swift code debugging #72601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Snowy1803
Copy link
Member

Because the data formatter for the compiler internals was registering itself as swift, it was hiding the default data formatters for swift code.

rdar://125114526

@Snowy1803 Snowy1803 requested a review from adrian-prantl March 26, 2024 22:50
@Snowy1803
Copy link
Member Author

@swift-ci please smoke test

@adrian-prantl
Copy link
Contributor

@swift-ci test

@adrian-prantl
Copy link
Contributor

******************** TEST 'Swift(macosx-x86_64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode-beta.app/Contents/Developer/usr/bin/python3 /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--
./utils/lldb/lldbSwiftDataFormatters.py:15:5: F841 local variable 'tName' is assigned to but never used
./utils/lldb/lldbSwiftDataFormatters.py:16:28: F541 f-string is missing placeholders
./utils/lldb/lldbSwiftDataFormatters.py:17:29: E127 continuation line over-indented for visual indent
./utils/lldb/lldbSwiftDataFormatters.py:19:29: E127 continuation line over-indented for visual indent
./utils/lldb/lldbSwiftDataFormatters.py:22:29: E127 continuation line over-indented for visual indent
./utils/lldb/lldbSwiftDataFormatters.py:25:29: E127 continuation line over-indented for visual indent

Because the data formatter for the compiler internals was registering itself as
swift, it was hiding the default data formatters for swift code.

rdar://125114526
@Snowy1803 Snowy1803 force-pushed the fix-lldb-dataformatters branch from d0f95f8 to 3581efc Compare March 27, 2024 17:03
@Snowy1803
Copy link
Member Author

@swift-ci please smoke test

Copy link
Contributor

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me thanks

@adrian-prantl adrian-prantl enabled auto-merge March 27, 2024 19:23
@adrian-prantl adrian-prantl merged commit b6348b0 into swiftlang:main Mar 27, 2024
@adrian-prantl
Copy link
Contributor

@Snowy1803 Could you also cherry-pick this to release/6.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants