5.10: [interop][SwiftToCxx] ensure Swift generic types can be used as template parameters to other Swift generic types in C++ #69523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additional copy Fixes swiftlang#69372
…lues are released after parameter copy is consumed
…C++ to Swift invocations
…eir ownership is not yet managed at the language boundary
…ate parameters to other Swift generic types in C++ rdar://117015962
|
@swift-ci please test |
DougGregor
approved these changes
Oct 30, 2023
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #69522, see last commit only for the diff - 1e75ae9
rdar://117015962
C++
isUsableInGenericContexttype trait in the generated header didn't correctly specialize for generic Swift types, leading to compile errors for users that exposed APIs that composed generic types of generic types, e.g.Optional<Array<Int>>. This change adds correctisUsableInGenericContextspecialization for generic types.