-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Linux] Enable frame pointers when building Swift libraries. #68988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
al45tair
merged 3 commits into
swiftlang:release/5.9.1
from
al45tair:eng/PR-116112040-5.9.1
Oct 6, 2023
Merged
[Linux] Enable frame pointers when building Swift libraries. #68988
al45tair
merged 3 commits into
swiftlang:release/5.9.1
from
al45tair:eng/PR-116112040-5.9.1
Oct 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn on frame pointers for the Swift runtime libraries. This makes backtraces that go through the runtimes more reliable without having to parse DWARF data. rdar://116112040
@swift-ci Please test |
tomerd
approved these changes
Oct 5, 2023
The test needs tweaking a little to work on Linux and macOS. rdar://116112040
@swift-ci Please test |
|
That doesn't seem to be something I've changed. |
Yeah, that's #68858. It deleted
but didn't remove
|
Somehow swiftlang#68858 managed to remove `config.swift_host_lib_dir` without removing the corresponding `config.substitutions.append`. Fix. rdar://116112040
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on frame pointers for the Swift runtime libraries. This makes backtraces that go through the runtimes more reliable without having to parse DWARF data.
rdar://116112040