NFC: Fix unused function and variable warnings #68870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
bnbarham
reviewed
Sep 29, 2023
Fixes the following warnings:
```
../swift-project/swift/lib/Frontend/PrintingDiagnosticConsumer.cpp:374:33: warning: unused function 'getSourceBufferStack' [-Wunused-function]
static SmallVector<unsigned, 1> getSourceBufferStack(
^
../swift-project/swift/lib/Sema/TypeCheckMacros.cpp:184:15: warning: unused variable 'ctx' [-Wunused-variable]
ASTContext &ctx = macro->getASTContext();
^
../swift-project/swift/lib/Sema/TypeCheckMacros.cpp:191:8: warning: unused variable 'sourceFile' [-Wunused-variable]
auto sourceFile = macro->getParentSourceFile();
^
../swift-project/swift/lib/Sema/TypeCheckMacros.cpp:999:13: warning: unused variable 'macroRole' [-Wunused-variable]
MacroRole macroRole =
^
../swift-project/swift/lib/Sema/TypeCheckMacros.cpp:165:25: warning: unused function 'handleExternalMacroDefinition' [-Wunused-function]
static MacroDefinition handleExternalMacroDefinition(
^
../swift-project/swift/lib/Sema/TypeCheckMacros.cpp:940:16: warning: unused function 'getRawMacroRole' [-Wunused-function]
static uint8_t getRawMacroRole(MacroRole role) {
^
```
tshortli
force-pushed
the
fix-macro-warnings
branch
from
50c0df8 to
8ebe83f
Compare
|
@swift-ci please smoke test |
bnbarham
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following warnings: