Sema: Only complain about the import when it does restrict the access level #68644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s level Fix the note pointing to the import when using a package type in a public declaration or inlinable code. We want a note on the import only when it actually lowers the access level of the imported decl. The note about a `package import` was simply be superfluous, while the same note about a `public import` would trigger an assert later on.
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 19, 2023
elsh
reviewed
Sep 19, 2023
| public import PublicLib | ||
| package import PackageLib | ||
|
|
||
| public func publicFuncUsesPackageLevelPublicImportedType(_ a: PackageLevelPublicImportedType) {} // expected-error {{function cannot be declared public because its parameter uses a package type}} |
There was a problem hiding this comment.
It should give the same error if PublicImportType is used here right?
There was a problem hiding this comment.
PublicImportType would be ok as long as it's publicly imported. It would show the same error for PackageImportType, with the note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the note pointing to the import when using a package type in a public declaration or inlinable code. We want a note on the import only when it actually lowers the access level of the imported decl.
The note about a
package importwas simply superfluous, while the same note about apublic importwould trigger an assert later on.