[embedded] Avoid use of a metatype in array implementation for embedded Swift #68614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
jckarter,
phausler,
zoecarver,
aschwaighofer and
eeckstein
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
phausler
approved these changes
Sep 19, 2023
slavapestov
reviewed
Sep 19, 2023
| @@ -41,9 +41,14 @@ func _allocateUninitializedArray<Element>(_ builtinCount: Builtin.Word) | |||
| if count > 0 { | |||
| // Doing the actual buffer allocation outside of the array.uninitialized | |||
| // semantics function enables stack propagation of the buffer. | |||
| let storageType: _ContiguousArrayStorage<Element>.Type | |||
| #if !$Embedded | |||
There was a problem hiding this comment.
Would it work to sink this down to getContiguousArrayStorageType()?
There was a problem hiding this comment.
I tried that originally, but the function call that returns a metatype is a problem in embedded Swift. I think we could improve the MandatoryPerfOptimizations to handle that case, but I think I'd like leave that option as a possible follow-up improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.