Skip to content

🌲 Disabling failing Linux tests for rebranch visibility #68329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Contributor

@etcwilde etcwilde commented Sep 5, 2023

Disabling on rebranch:

  • Frontend/dependencies-fine.swift
  • DebugInfo/BridgingHeaderPCH.swift
  • DebugInfo/ClangModuleBreadcrumbs.swift

Trying to see where the rest of the toolchain build stands on Linux.

Disabling failing tests:
 - DebugInfo/BridgingHeaderPCH.swift
 - DebugInfo/ClangModuleBreadcrumbs.swift

Trying to get more visibility on Linux for rebranch status.
Radar to track fixing these test failures: rdar://114728459
Disabling failing test:
 - Frontend/dependencies-fine.swift

Trying to get more visibility on Linux for rebranch status.
Radar to track fixing this test failure: rdar://114207865
@etcwilde
Copy link
Contributor Author

etcwilde commented Sep 5, 2023

@swift-ci please smoke test

@etcwilde
Copy link
Contributor Author

etcwilde commented Sep 5, 2023

I expect failures, but macOS and Linux should both be failing during the SwiftPM build.

@etcwilde etcwilde merged commit 75c3baf into swiftlang:rebranch Sep 5, 2023
@beccadax
Copy link
Contributor

beccadax commented Sep 8, 2023

@compnerd Could your changes in #68302 have caused Frontend/dependencies-fine.swift to start running on Linux when it previously did not? The test appears to import Objective-C code when clang is not configured to parse it, which causes a cascade of errors where clang has a really hard time understanding things like id and @class as plain C.

@compnerd
Copy link
Member

compnerd commented Sep 8, 2023

It seems unlikely to me, the removed aspects were:

// REQUIRES: shell
// Also uses awk:
// XFAIL OS=windows

shell should be available on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants