Driver: virtualise the plugin path handling #68322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin layouts are different across platforms. Move this into a virtual method and allow replacement. On Windows, the plugins are placed into the `bin` directory as the DLLs should always be co-located to ensure that the proper DLLs are found (there is no concept of RPATH).
|
@swift-ci please smoke test |
This was referenced Sep 4, 2023
compnerd
added a commit
to compnerd/swift-driver
that referenced
this pull request
Sep 4, 2023
The test suite is currently entirely broken on Windows (awaiting @cachemeifyoucan to fix swiftlang#1431). This speculatively changes the driver to alter the search paths to match swiftlang/swift#68322).
compnerd
added a commit
to compnerd/swift-driver
that referenced
this pull request
Sep 7, 2023
The test suite is currently entirely broken on Windows (awaiting @cachemeifyoucan to fix swiftlang#1431). This speculatively changes the driver to alter the search paths to match swiftlang/swift#68322).
compnerd
added a commit
to compnerd/swift-driver
that referenced
this pull request
Sep 7, 2023
The test suite is currently entirely broken on Windows (awaiting @cachemeifyoucan to fix swiftlang#1431). This speculatively changes the driver to alter the search paths to match swiftlang/swift#68322).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin layouts are different across platforms. Move this into a virtual method and allow replacement. On Windows, the plugins are placed into the
bindirectory as the DLLs should always be co-located to ensure that the proper DLLs are found (there is no concept of RPATH).