ASTGen: account for alternate path separators #68291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
CodaFi
reviewed
Sep 3, 2023
lib/ASTGen/Sources/ASTGen/SourceManager+MacroExpansionContext.swift
Outdated
Show resolved
Hide resolved
Windows supports `\` and `/` as path separators. Account for both in computing the basename. This repairs a few test failures on Windows.
There is no real reason to split the behaviour here as this is a file system primitive. Special case Apple and Linux platforms to address feedback.
compnerd
force-pushed
the
split-em-up
branch
from
97c80b5 to
a61e6e7
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows supports
\and/as path separators. Account for both in computing the basename. This repairs a few test failures on Windows.