🍒[cxx-interop] Look up NSNotificationName in C++ language mode properly
#68279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 38820c1)
This change makes sure that `NSNotification.Name.NEVPNStatusDidChange` is imported correctly when C++ interop is enabled. `importer::findSwiftNewtype` is called while writing Clang modules, at a point when the translation-unit scope does not exist (`clangSema.TUScope` is `nullptr`). That prevents the Clang lookup from discovering `NSNotificationName` declaration. Instead of trying to pass a translation-unit scope to Clang, let's use qualified name lookup which does not require a scope. rdar://112199372 (cherry picked from commit e956e8a)
|
@swift-ci please test |
DougGregor
approved these changes
Sep 1, 2023
|
is it fixed in Xcode 15 right now? , because i have this problem |
|
never mind , i have fixed it with adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that
NSNotification.Name.NEVPNStatusDidChangeis imported correctly when C++ interop is enabled.importer::findSwiftNewtypeis called while writing Clang modules, at a point when the translation-unit scope does not exist (clangSema.TUScopeisnullptr).That prevents the Clang lookup from discovering
NSNotificationNamedeclaration.Instead of trying to pass a translation-unit scope to Clang, let's use qualified name lookup which does not require a scope.
Original PR: #68217
rdar://112199372