Build the fragile swiftCxx statically on all platforms #68239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library is still fragile as C++ Interop is in preview. Mark it as fragile to match cxxStdlib.
This adjusts Cxx to be built statically on all platforms including Windows. The static library support is sufficient to support this module linking statically on Windows.
Remove flag that is unsupported on 5.9
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please build toolchain windows platform |
DougGregor
approved these changes
Aug 31, 2023
|
Please test with following PRs: @swift-ci please build toolchain windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the Cxx module as fragile and build it statically on all platforms. C++ Interop is an upcoming feature and has not yet declared ABI stability and so is always meant to be statically linked.