[AddressLowering] Fix partial_apply argument indexing. #67947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added convenience functions to ApplySite to access argument and argument operand by index into the callee's argument list (rather than by index into the arguments used by the apply instruction).
Full apply instructions have the same number of arguments as the callee has parameters. Partial apply instructions have some number less than or equal to the number of callee parameters.
When rewriting arguments, the index used is into the callee's argument list. For full applies, that is identical to the index into the instruction's argument list. For partial applies, it is not. Previously, though, the index was used as if it were an index into the instruction's argument list to get an argument ref. Here, use instead the newly added convenience to get the argument ref using the index into the callee's arguments.
|
@swift-ci please test |
nate-chandler
changed the title
nate-chandler
deleted the
opaque-values/20230815/1/partial-apply-indexing
branch
atrick
reviewed
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rewriting arguments, the index used is into the callee's argument list. For full applies, that is identical to the index into the instruction's argument list. For partial applies, it is not.
Previously, though, the index was used as if it were an index into the instruction's argument list to get an argument ref. Here, use instead the newly added convenience to get the argument ref using the index into the callee's arguments.