Replace bespoke Sendable and Copyable conformance on tuples with tuple conformances #67839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
AnthonyLatsis,
ktoso,
tshortli,
zoecarver,
hyp and
egorzhdan
as code owners
…Decls in the Builtin module
…n.TheTupleType to Sendable and Copyable
…inProtocolConformance
slavapestov
force-pushed
the
tuple-conformance-sendable-copyable
branch
from
6a6e131 to
a1f816d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
tuple-conformance-sendable-copyable
branch
from
a1f816d to
c26cafc
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully NFC. These now behave as if they were declared in the following way:
However we don't want to use experimental source language features in the standard library, so I hacked the compiler to conjure up the extension declarations in the Builtin module instead. Once we have real syntax for tuple conformances we can move the declarations to the standard library. The old mechanism, which predates parameter packs and synthesizes a fake generic signature for each tuple arity, is no longer needed.