[CodeCompletion] Add fake type annotation to custom attributes #67806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham and
hamishknight
as code owners
rintaro
commented
Aug 8, 2023
rintaro
commented
Aug 8, 2023
rintaro
force-pushed
the
ide-completion-fakeannotation-rdar109062582
branch
from
59c1c86 to
d7f41eb
Compare
|
@swift-ci Please smoke test |
ahoppen
reviewed
Aug 8, 2023
lib/IDE/CompletionLookup.cpp
Outdated
| @@ -1822,9 +1886,13 @@ void CompletionLookup::addMacroExpansion(const MacroDecl *MD, | |||
| Builder.addRightParen(); | |||
| } | |||
|
|
|||
| if (!MD->getResultInterfaceType()->isVoid()) { | |||
| auto roles = MD->getMacroRoles(); | |||
| if (roles.containsOnly(MacroRole::Extension)) { | |||
There was a problem hiding this comment.
Why do we need to handle extension macros specially here?
There was a problem hiding this comment.
It's a typo of Expression 😉
lib/IDE/CompletionLookup.cpp
Outdated
Comment on lines
1684
to
1685
| if (attrRoleStrs.size() == 0) | ||
| return attrRoleStrs[0]; |
There was a problem hiding this comment.
Shouldn't this be attrRoleStrs.size() == 1?
lib/IDE/CompletionLookup.cpp
Outdated
Comment on lines
1841
to
1842
| if (roles.contains(MacroRole::Extension)) | ||
| roleStrs.push_back("Extension Macro"); |
There was a problem hiding this comment.
Look like this case is duplicated from above?
lib/IDE/CompletionLookup.cpp
Outdated
| if (attrRoleStrs.size() == 0) | ||
| return attrRoleStrs[0]; | ||
|
|
||
| stash.clear(); |
There was a problem hiding this comment.
Instead of clearing, would it be better to assert that it's empty? As otherwise, callers relying on a StringRef may be surprised that calling again could potentially empty it out.
Macros and custom attribute types (i.e. `@resultBuilder`, `@propertyWrapper`, and `@globalActor`) now have fake type annotations. This would be useful to recognize which candidates are actually usable in code completions after `@`. rdar://109062582
rintaro
force-pushed
the
ide-completion-fakeannotation-rdar109062582
branch
from
d7f41eb to
fcaae5c
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros and custom attribute types (i.e.
@resultBuilder,@propertyWrapper, and@globalActor) now have fake type annotations. This would be useful to recognize which candidates are actually usable in code completions after@.rdar://109062582