-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Enable CxxStdlib on Windows #67743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CxxStdlib on Windows #67743
Conversation
@swift-ci please build toolchain Windows platform |
@swift-ci please smoke test |
Please test with following PRs: @swift-ci please build toolchain Windows platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you @compnerd!
Please test with following PRs: @swift-ci please build toolchain Windows platform |
Okay, seems that packaging is not yet ready for this. I am going to merge this anyway - we just won't be distributing the files for now. This should at least give us some coverage from the testing side. |
Bleh, seems that rebase is not enabled, okay, then I'll split this up. The underlying change is the one that should resolve the issue that @eeckstein hit, the top most commit needs a bit more tweaking anyway to ensure that we don't collide on things. |
Windows names static libraries with a `lib` prefix and a `lib` suffix. This differentiates them from the import libraries which have no prefix and a `lib` suffix. This adjustment enables the parallel installation of import libraries and static library variants for a given module. This is required to support static and dynamic library co-existence in Swift.
Enable this module on Windows for enabling C++ Interop.
Please test with following PRs: @swift-ci please build toolchain Windows platform |
Please test with following PRs: @swift-ci please build toolchain Windows platform |
@swift-ci please smoke test |
This improves the C++ interop support on Windows by mitigating a clang issue in the build system when building natively and enables the CxxStdlib module.