Skip to content

Enable CxxStdlib on Windows #67743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Enable CxxStdlib on Windows #67743

merged 2 commits into from
Aug 5, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Aug 4, 2023

This improves the C++ interop support on Windows by mitigating a clang issue in the build system when building natively and enables the CxxStdlib module.

@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#220

@swift-ci please build toolchain Windows platform

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you @compnerd!

@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#220

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

Okay, seems that packaging is not yet ready for this. I am going to merge this anyway - we just won't be distributing the files for now. This should at least give us some coverage from the testing side.

@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

Bleh, seems that rebase is not enabled, okay, then I'll split this up. The underlying change is the one that should resolve the issue that @eeckstein hit, the top most commit needs a bit more tweaking anyway to ensure that we don't collide on things.

Windows names static libraries with a `lib` prefix and a `lib` suffix.
This differentiates them from the import libraries which have no prefix
and a `lib` suffix.  This adjustment enables the parallel installation
of import libraries and static library variants for a given module.
This is required to support static and dynamic library co-existence in
Swift.
Enable this module on Windows for enabling C++ Interop.
@compnerd
Copy link
Member Author

compnerd commented Aug 5, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#220

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Aug 5, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#220

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Aug 5, 2023

@swift-ci please smoke test

@compnerd compnerd merged commit aa5436d into swiftlang:main Aug 5, 2023
@compnerd compnerd deleted the hacks-r-us branch August 5, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants