[C++20] Remove u8
string literal prefixes.
#67707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++20,
u8
literals create values of typechar8_t[]
instead ofchar[]
, and these can't be implicitly converted.Plan: Try just removing them first to see if any of our CI environments complain with un-prefixed Unicode strings. If they do, we can try introducing a macro that expands to
u8
for C++<20 and to nothing for C++≥20. In some hypothetical future when everything is built in C++20 mode, we would want to address the usages then by explicitly usingchar8_t
where needed.