[Code Health] Improve eventual C++20 support. #67683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors. In C++20, types that declare or delete their default/copy/move constructors are no longer aggregates, so the aggregate uses of these types will not compile under C++20. Adding them fixes this, without affecting older language modes.
These were never allowed, but with C++20 making more `vector` functions `constexpr`, they would start causing build failures in that language mode.
…ed-value problems.
allevato
requested review from
hborla,
slavapestov,
xedin and
artemcm
as code owners
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
compnerd
approved these changes
Aug 3, 2023
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small set of patches we've been floating for a while, to allow Swift to be built in a C++20 configuration. This PR contains the following changes:
std::vectorare complete and not just forward-declared.LinkEntityis zero-initialized to avoid use-of-uninitialized-value problems.All should remain compatible with earlier C++ versions as well.