Skip to content

Handle variadic tuples in reabstraction thunk emission #67040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2023
Merged

Handle variadic tuples in reabstraction thunk emission #67040

merged 4 commits into from
Jun 30, 2023

Conversation

rjmccall
Copy link
Contributor

Fixes rdar://110391963

@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@rjmccall rjmccall force-pushed the variadic-tuple-result-reabstraction-thunks branch from 6986dc1 to ec141f2 Compare June 30, 2023 02:21
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@rjmccall rjmccall force-pushed the variadic-tuple-result-reabstraction-thunks branch from ec141f2 to 00e78cb Compare June 30, 2023 05:13
@rjmccall rjmccall requested a review from eeckstein as a code owner June 30, 2023 05:13
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

rjmccall added 2 commits June 30, 2023 02:08
@rjmccall
Fix some SILArgument infrastructure for pack results.
65e2e8c 
Getting this right convinces the memory verifier to not complain
about untouched empty pack result arguments, which should be
innocuous.
@rjmccall
Handle vanishing and variadic tuple results in reabstraction thunks.
c0777e6 
Fixes rdar://110391963
@rjmccall rjmccall force-pushed the variadic-tuple-result-reabstraction-thunks branch from 00e78cb to c0777e6 Compare June 30, 2023 06:09
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

eeckstein
eeckstein approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIL changes lgtm.
(I'm not really the right person to review SILGen changes)

@rjmccall
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@rjmccall rjmccall mentioned this pull request Jun 30, 2023
Merged
@rjmccall
Copy link
Contributor Author

The test failure in the full macOS run (test/ModuleInterface/distributed_actors.swift on iphonesimulator-x86_64) is unrelated to my PR and showing up in other builds.

@xedin
Copy link
Contributor

xedin commented Jun 30, 2023

I opened a revert PR for this new test Konrad added - #67054

@rjmccall rjmccall merged commit 61e8585 into swiftlang:main Jun 30, 2023
@rjmccall rjmccall deleted the variadic-tuple-result-reabstraction-thunks branch June 30, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmccall @xedin @eeckstein