[Freestanding] Remove uses of stat() and dlsym(). #66883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
force-pushed
the
eng/PR-111214571
branch
from
0f45d2e to
ecdf75a
Compare
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
|
@swift-ci Please smoke test |
al45tair
force-pushed
the
eng/PR-111214571
branch
from
ecdf75a to
3e08082
Compare
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
|
@swift-ci Please smoke test |
We shouldn't be using stat() or dlsym() in the freestanding runtime. rdar://111214571 rdar://106555012
al45tair
force-pushed
the
eng/PR-111214571
branch
from
3e08082 to
e5ece81
Compare
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows platform |
|
Oops. I hit the Merge button prematurely. It's passed all the tests but nobody actually reviewed it. I think it should be fine, but if anyone has any problem with it, please revert and I'll raise a new PR to fix. |
This was referenced Jun 28, 2023
|
LGTM! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be using stat() or dlsym() in the freestanding runtime.
rdar://111214571
rdar://106555012