🍒 [5.9] Fix case mismatch in test error message expectation #66154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbkka
approved these changes
May 25, 2023
ktoso
changed the title
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #66138
A CI failure caused by validation of independent features racing. This change unbreaks CI.
The 5.9 PRs:
two PRs "racing" and thus ending up with broken main:
CI tested those independently and both passed.
Once they got merged into main, the changed diagnostic from (2) caused the new test in (1) to fail on a typo.
This was resolved in: Fix case mismatch in test error message expectation #66138
Technically merge queues prevent such issues, but would add even more potential wait time to merge changes.
Some "middle ground" would be amazing to find but I don't think something automated exists for this yet.