-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.8][CMake] Don't add an extraneous rpath to the swift-frontend #66122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edymtt
approved these changes
May 25, 2023
@swift-ci please test |
@swift-ci please build toolchain |
Mac CI failure is unrelated:
|
@swift-ci please test macOS |
1 similar comment
@swift-ci please test macOS |
The generated toolchains for Linux and macOS look good rpath-wise
|
Ping @tomerd, can we get this in for the next patch release now that 5.8.1 shipped? |
tomerd
approved these changes
Jun 9, 2023
airspeedswift
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #64103
Explanation: The 5.8 release has an incorrect relative runpath added to the compiler on linux, the second one:
This pull fixes that, removing a mild security risk when running the compiler.
Scope: Only affects the compiler runpath on linux
Issue: None
Risk: low, as it only removes an unused runpath for the linux compiler
Testing: Passed all CI on trunk
Reviewer: @edymtt