Skip to content

[Backtracing][Tests] Disable crashing tests under ASAN. #66074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented May 23, 2023

If ASAN is enabled, it will catch the crashes and the backtracing code won't, so in that case the tests will fail. Fix by disabling them for ASAN.

rdar://109706334

@al45tair al45tair requested a review from a team as a code owner May 23, 2023 10:02
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 23, 2023
@al45tair
Copy link
Contributor Author

al45tair commented May 23, 2023

Explanation: Some of the backtracer tests crash deliberately and look to make sure the backtracer is generating the right output. When ASAN is enabled, it catches the crashes instead of the backtracer catching them, so the output doesn't match. Therefore, disable these tests for ASAN builds.
Risk: Low. Only affects tests.
Original PR: #64567
Reviewed by: @mikeash
Resolves: rdar://109706334
Tests: This just disables the tests (unfortunately we also have to update a load of line numbers in the test output at the same time, but c'est la vie.)

@al45tair al45tair force-pushed the eng/PR-109706334 branch from d352466 to 8b49f02 Compare May 23, 2023 12:21
If ASAN is enabled, it will catch the crashes and the backtracing code
won't, so in that case the tests will fail.  Fix by disabling them for
ASAN.

rdar://107129465
@al45tair al45tair force-pushed the eng/PR-109706334 branch from 8b49f02 to 4639799 Compare May 24, 2023 06:53
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair al45tair merged commit 5b184b3 into swiftlang:release/5.9 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants