Skip to content

[Tools] Fix macro demangling. #66050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

al45tair
Copy link
Contributor

The code in swift-demangle to cope with macro demangling was slightly wrong. Fix it.

rdar://109649226

The code in swift-demangle to cope with macro demangling was slightly
wrong.  Fix it.

rdar://109649226
@al45tair al45tair requested a review from DougGregor May 22, 2023 10:10
@al45tair al45tair requested a review from a team as a code owner May 22, 2023 10:10
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 22, 2023
@al45tair
Copy link
Contributor Author

Explanation: Fixes an error in swift-demangle when scanning for macro manglings.
Risk: Low. Only affects swift-demangle.
Original PR: #66049
Reviewed by: @DougGregor
Resolves: rdar://109151498 (original resolved rdar://106375185)
Tests: There are already a couple of manglings of this kind in test/Demangle/Inputs/manglings.txt, so this should fix the test (not that I've seen a test failure here — I just spotted this bug while looking at the code.)

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair al45tair merged commit 82b3e75 into swiftlang:release/5.9 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants