[Diagnostics] Suppress unused expression warning if result is discard… #65445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able pack expansion Examine pack expansion pattern to determine whether expression result could be discarded without a warning (applies to tuples with a single unlabeled pack expansion element as well). Resolves: rdar://108064941
|
@swift-ci please test |
hborla
approved these changes
Apr 27, 2023
| } | ||
|
|
||
| func test2<each T>(_ value: repeat each T) { | ||
| ((repeat arr.append(each value))) // no warning |
There was a problem hiding this comment.
Is there any reason to do this with a tuple instead of just writing the underlying pack expansion expression? I'm wondering if we should still diagnose this for tuples
There was a problem hiding this comment.
I did it that way because users don't actually know that this is a tuple, syntactically it's just parens which seems reasonable to make consistent with non-variadic cases.
|
@swift-ci please smoke test macOS platform |
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able pack expansion
Examine pack expansion pattern to determine whether expression
result could be discarded without a warning (applies to tuples with
a single unlabeled pack expansion element as well).
Resolves: rdar://108064941