Skip to content

[interop] do not assume we need to IRGen destructors of fields inside… #64623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Mar 25, 2023

… a record with an explicit destructor

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Mar 25, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners March 25, 2023 00:08
@hyp
Copy link
Contributor Author

hyp commented Mar 25, 2023

@swift-ci please test and merge

2 similar comments
@hyp
Copy link
Contributor Author

hyp commented Mar 25, 2023

@swift-ci please test and merge

@hyp
Copy link
Contributor Author

hyp commented Mar 25, 2023

@swift-ci please test and merge

@hyp
Copy link
Contributor Author

hyp commented Mar 26, 2023

@swift-ci please smoke test macOS

@hyp
Copy link
Contributor Author

hyp commented Mar 26, 2023

Looks like there's a legit issue on macOS while building iOS benchmarks. Investigating.

@hyp hyp force-pushed the eng/fix-record-des-visit branch from 1f021b9 to b5766fd Compare March 26, 2023 19:25
@hyp
Copy link
Contributor Author

hyp commented Mar 26, 2023

@swift-ci please test and merge

@swift-ci swift-ci merged commit 5ef25e7 into swiftlang:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants